-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize General Meeting page #686
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fetch data from google sheets to populate fields in skeleton gm page
Created a script to pull data from Google Sheets; the new town-hall page automatically populates the data. Still need to work on processing data from past town hall meetings.
NOTE: The Winter 2021 Town Hall Metting is still static b/c of the video
This eases access to the town hall page. /town-hall/town-hall --> /town-hall
_redirects: Remove redirect on /town-hall netlify.toml: Add 'npm run thp' before build package.json: Add thp script lint.yml: Add '- run: npm run thp' node-build.yml: Add '- run: npm run thp'
…s to use generator script
ArshMalik02
reviewed
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two comments in code to update the GitHub workflows. Everything else lgtm, great work!!
ArshMalik02
approved these changes
May 15, 2024
snigdha-kansal
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #671 by creating a dynamic general meeting page
gm.js
in the/pages/
directory. This page populates the website with data retrieved fromgmData.json
, which is generated by the scriptgm-generator.mjs
in the/scripts/
directory. The generator script runs before the build process to fetch data from this spreadsheet. For testing, access the page at localhost:3000/gm through the development server.Changes
pages/gm.js
(NEW)scripts/gm-generator.mjs
(NEW)gmData.json
googleapi
package.json
gmp
script:node scripts/gm-generator.mjs
npm run gmp
in the build script.gitignore
:gmData.json
netlify.toml
npm run gmp
beforenpm build
lint.yml
run: npm run gmp
node-build.yml
- run: npm run gmp
Possible Changes
/pages/gm
directory, so we can either delete them or leave them for the users to access (e.g. https://www.uclaacm.com/gm/w24)